Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Refactor] Support imvoxelnet @ SUN RGB-D on 1.x branch #2141

Merged
merged 8 commits into from
Jan 5, 2023

Conversation

Tai-Wang
Copy link
Member

@Tai-Wang Tai-Wang commented Dec 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.
Support imvoxelnet @ SUN RGB-D on 1.x branch.

Modification

Please briefly describe what modification is made in this PR.

  • Refactor imvoxelnet detector, neck, head
  • Add refactored config
  • Add refactored unit test

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Tai-Wang Tai-Wang changed the title [WIP][Refactor] Support imvoxelnet @ SUN RGB-D on 1.x branch [Refactor] Support imvoxelnet @ SUN RGB-D on 1.x branch Dec 27, 2022
@ZwwWayne ZwwWayne requested a review from ZCMax January 5, 2023 05:12
@ZwwWayne ZwwWayne merged commit 9073a3b into open-mmlab:dev-1.x Jan 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants