Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support waymo_info_test.pkl and ImageSets generating #2180

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

ZLTJohn
Copy link
Contributor

@ZLTJohn ZLTJohn commented Dec 28, 2022

Motivation

Currently, mmdet3d-dev1.x cannot generate waymo_info_test.pkl for testing or testing_camera_only properly.
This PR is aiming at fixing it.

Modification

  1. create_data.py
    • Add function call create_ImageSets_img_ids() to generate ImageSets according to data in kitti_format/
    • Add function call update_pkl_infos('waymo', out_dir=out_dir, pkl_path=test_path) to update test info generated in kitti.create_waymo_info_file(...)
  2. kitti_data_utils.py
    • Detach timestamp collecting from velodyne_path collecting. timestamp is very important link between kitti_format data and tfrecords data, so we still need to collect it even if no lidar data provided. PR More customizable and Faster waymo evaluation #2179 also need timestamps in waymo_infos_*.pkl to generate idx2metainfo.pkl
  3. updata_infos_to_v2.py
    • Use dict.get(key) methods instead of dict[key] methods to support updating info files without lidar data or annotations. Now function update_waymo_infos is able to update waymo_infos_test.pkl or the camera-only one.
  4. waymo_converter.py
    • Delete this line and add if range_image_top_pose is None: return in function save_lidar. In this way, we don't need to judge if the split is camera_only or not.
    • [TODO] We can also promt user that we lack lidar data in that split.
    • Add create_ImageSets_img_ids to support ImageSets generating.

Issue

Currently the easiest way to generate waymo camera-only test set pkl file is renaming testing_3d_camera_only_detection to testing, and turn off velodyne in WaymoInfoGatherer. Actually, simply adding an item could only generate cam-only test data in kitti_format but offers no pkl file. How do we plan to fix it?

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 45.23% // Head: 45.23% // No change to project coverage 👍

Coverage data is based on head (9dd1f15) compared to base (edc468b).
Patch has no changes to coverable lines.

❗ Current head 9dd1f15 differs from pull request most recent head 008131d. Consider uploading reports for the commit 008131d to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2180   +/-   ##
========================================
  Coverage    45.23%   45.23%           
========================================
  Files          253      253           
  Lines        20729    20729           
  Branches      3275     3275           
========================================
  Hits          9377     9377           
  Misses       10733    10733           
  Partials       619      619           
Flag Coverage Δ
unittests 45.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tai-Wang
Copy link
Member

Tai-Wang commented Feb 8, 2023

Please @lianqing11 double-check.

@ZwwWayne ZwwWayne merged commit 5a658d6 into open-mmlab:dev-1.x Feb 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants