-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Feature] Add panoptic segmentation loading. #2223
Conversation
It seems that we need to load |
In datasets like semanticKITTI and nuScenes, both semantic labels and instance labels are in the same file, so I want to load them together in one function. For example, labels of semanticKITTI are constructed in the form of |
From my perspective, we need to split the original annotation label into |
Do you mean split labels with some preprocess? I think maybe it is not a good idea because it will occupy extra memory and therefore not friendly for user. Maybe I can implement one version of m y method and see if it suits. |
Please merge the latest dev-1.x and resolve the conflicts. |
Codecov ReportBase: 46.39% // Head: 47.08% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2223 +/- ##
===========================================
+ Coverage 46.39% 47.08% +0.68%
===========================================
Files 259 261 +2
Lines 21401 21674 +273
Branches 3379 3424 +45
===========================================
+ Hits 9930 10206 +276
+ Misses 10827 10815 -12
- Partials 644 653 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add panoptic loading in LoadAnnotations3D for semanticKITTI and nuScenes.
Modification
Add _load_panoptic_seg_3d in LoadAnnotations3D. It simply loads panoptic labels from panoptic paths. The labels of segmentation datasets like semanticKITTI and nuScenes need further processing to get semantic labels and instance labels.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist