Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Panoptic segmentation metric #2230

Merged
merged 17 commits into from
Feb 15, 2023

Conversation

xizaoqu
Copy link
Contributor

@xizaoqu xizaoqu commented Jan 18, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add 3D panoptic segmentation metric for semanticKITTI.

Modification

Add 3D panoptic segmentation metric. NOTE: To verify the metric, this PR also includes the corresponding utils, but there are not merged into the repo yet.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12
Copy link
Contributor

Please fix the lint

@xizaoqu
Copy link
Contributor Author

xizaoqu commented Jan 30, 2023

Please fix the lint

I've fixed them. Please check.

@JingweiZhang12
Copy link
Contributor

The code LGTM. Please pull the latest code which has fixed the lint about isort. @xizaoqu

@JingweiZhang12 JingweiZhang12 requested review from sunjiahao1999 and removed request for sunjiahao1999 February 8, 2023 02:23
@JingweiZhang12
Copy link
Contributor

@sunjiahao1999 Please review this PR.

@sunjiahao1999
Copy link
Collaborator

Fix lint error.

mmdet3d/evaluation/metrics/panoptic_seg_metric.py Outdated Show resolved Hide resolved
mmdet3d/evaluation/metrics/panoptic_seg_metric.py Outdated Show resolved Hide resolved
mmdet3d/evaluation/metrics/panoptic_seg_metric.py Outdated Show resolved Hide resolved
mmdet3d/evaluation/metrics/panoptic_seg_metric.py Outdated Show resolved Hide resolved
mmdet3d/evaluation/functional/panoptic_seg_eval.py Outdated Show resolved Hide resolved
mmdet3d/evaluation/functional/panoptic_seg_eval.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 46.39% // Head: 47.04% // Increases project coverage by +0.64% 🎉

Coverage data is based on head (bb8bad3) compared to base (6810244).
Patch coverage: 90.94% of modified lines in pull request are covered.

❗ Current head bb8bad3 differs from pull request most recent head 30d40b7. Consider uploading reports for the commit 30d40b7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2230      +/-   ##
===========================================
+ Coverage    46.39%   47.04%   +0.64%     
===========================================
  Files          259      261       +2     
  Lines        21401    21635     +234     
  Branches      3379     3417      +38     
===========================================
+ Hits          9930    10178     +248     
+ Misses       10827    10807      -20     
- Partials       644      650       +6     
Flag Coverage Δ
unittests 47.04% <90.94%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
mmdet3d/visualization/local_visualizer.py 33.90% <0.00%> (-0.36%) ⬇️
mmdet3d/models/segmentors/encoder_decoder.py 17.20% <72.72%> (ø)
mmdet3d/models/segmentors/base.py 57.69% <75.00%> (+5.06%) ⬆️
mmdet3d/evaluation/metrics/panoptic_seg_metric.py 90.00% <90.00%> (ø)
mmdet3d/datasets/dataset_wrappers.py 92.64% <92.59%> (+67.64%) ⬆️
mmdet3d/evaluation/functional/panoptic_seg_eval.py 93.45% <93.45%> (ø)
mmdet3d/evaluation/functional/__init__.py 100.00% <100.00%> (ø)
mmdet3d/evaluation/metrics/__init__.py 100.00% <100.00%> (ø)
mmdet3d/models/decode_heads/decode_head.py 78.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne
Copy link
Collaborator

last round, the overall LGTM

@xizaoqu
Copy link
Contributor Author

xizaoqu commented Feb 14, 2023

last round, the overall LGTM

I've fixed the problems.

@ZwwWayne ZwwWayne merged commit 4cfae3f into open-mmlab:dev-1.x Feb 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants