-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Fix] fix local_visualizer.py: only visualize when there is at least one instance #2231
[Fix] fix local_visualizer.py: only visualize when there is at least one instance #2231
Conversation
- fix "AttributeError: ‘InstanceData’ object has no attribute ‘bboxes_3d’" error
Please pull the latest code to fix lint issue and change your base to |
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
- add exception handling when there is no instance inside pred_instances_3d
|
…pty instance - Add exception handling when instances are empty - Delete the exception handling previously added to add_datasample
@Xiangxu-0103 Please approve the circle ci work flow :) |
Codecov ReportBase: 46.39% // Head: 46.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2231 +/- ##
===========================================
- Coverage 46.39% 46.39% -0.01%
===========================================
Files 259 259
Lines 21401 21404 +3
Branches 3379 3380 +1
===========================================
Hits 9930 9930
- Misses 10827 10829 +2
- Partials 644 645 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi @404Vector !First of all, we want to express our gratitude for your significant PR in the MMDet. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
An error occurs when drawing a 3d box on an image to evaluate model performance as shown below.
python tools/test.py configs/smoke/smoke_dla34_dlaneck_gn-all_4xb8-6x_kitti-mono3d.py checkpoints/smoke/smoke_dla34_pytorch_dlaneck_gn-all_8x4_6x_kitti-mono3d_20210929_015553-d46d9bb0.pth --show --show-dir='work_dirs/test' --task='mono_det'
Motivation
I wanted to draw a 3D BBox using tools/test.py.
However, it could not be drawn due to an internal error.
I'll fix the error with this PR.
Modification
file : mmdet3d/visualization/local_visualizer.py
Looking at the data_sample object at runtime, it has gt_instances_3d.
But inside gt_instances_3d the data doesn't exist.
Fix the bug by modifying the code as shown below.
Checklist
fix #2119