Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Add TR3D detector to projects #2274

Merged
merged 8 commits into from
Feb 20, 2023
Merged

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Feb 14, 2023

Modification

Add TR3D detector in ScanNet, SUN RGB-D and S3DIS to projects/TR3D.

BC-breaking (Optional)

No

@filaPro filaPro changed the base branch from master to dev-1.x February 14, 2023 16:35
@ZwwWayne
Copy link
Collaborator

Hi @filaPro ,
Thanks for your kind contribution. Overall, this PR looks good. We can merge this PR after fixing small comments.

@ZwwWayne ZwwWayne added this to the 1.1.0rc4 milestone Feb 15, 2023
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 46.39% // Head: 47.09% // Increases project coverage by +0.69% 🎉

Coverage data is based on head (e047fd0) compared to base (6810244).
Patch coverage: 86.52% of modified lines in pull request are covered.

❗ Current head e047fd0 differs from pull request most recent head 423ce57. Consider uploading reports for the commit 423ce57 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2274      +/-   ##
===========================================
+ Coverage    46.39%   47.09%   +0.69%     
===========================================
  Files          259      261       +2     
  Lines        21401    21679     +278     
  Branches      3379     3425      +46     
===========================================
+ Hits          9930    10210     +280     
+ Misses       10827    10816      -11     
- Partials       644      653       +9     
Flag Coverage Δ
unittests 47.09% <86.52%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
mmdet3d/testing/data_utils.py 70.83% <ø> (ø)
mmdet3d/datasets/transforms/formating.py 58.03% <33.33%> (+1.78%) ⬆️
mmdet3d/datasets/transforms/loading.py 48.13% <60.60%> (+0.79%) ⬆️
mmdet3d/visualization/local_visualizer.py 34.01% <63.15%> (-0.25%) ⬇️
mmdet3d/models/backbones/mink_resnet.py 25.00% <70.00%> (+2.19%) ⬆️
mmdet3d/models/segmentors/encoder_decoder.py 17.20% <72.72%> (ø)
mmdet3d/models/segmentors/base.py 57.69% <75.00%> (+5.06%) ⬆️
mmdet3d/visualization/vis_utils.py 40.47% <75.00%> (+1.19%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

projects/TR3D/README.md Outdated Show resolved Hide resolved
projects/TR3D/configs/tr3d.py Outdated Show resolved Hide resolved
projects/TR3D/configs/tr3d_1xb16_s3dis-3d-5class.py Outdated Show resolved Hide resolved
projects/TR3D/configs/tr3d_1xb16_scannet-3d-18class.py Outdated Show resolved Hide resolved
projects/TR3D/configs/tr3d_1xb16_sunrgbd-3d-10class.py Outdated Show resolved Hide resolved
projects/TR3D/README.md Show resolved Hide resolved
projects/TR3D/configs/tr3d_1xb16_s3dis-3d-5class.py Outdated Show resolved Hide resolved
projects/TR3D/tr3d/rotated_iou_loss.py Show resolved Hide resolved
projects/TR3D/tr3d/tr3d_head.py Outdated Show resolved Hide resolved
projects/TR3D/tr3d/transforms_3d.py Show resolved Hide resolved
@Xiangxu-0103
Copy link
Collaborator

Overall, this PR LGTM.

@ZwwWayne
Copy link
Collaborator

Hi @filaPro ,
This PR is OK to be merged. Would you like to update the links of models, logs, and their log.json? It is fine if you provide a way for us to download and upload them to our host, then we can send the links to you for update.

@filaPro
Copy link
Contributor Author

filaPro commented Feb 19, 2023

Hi @ZwwWayne ,
Can you please upload tr3d_* from here and provide the links?

@Tai-Wang
Copy link
Member

Tai-Wang commented Feb 20, 2023

Hi @filaPro , I have uploaded the checkpoints and logs to our server. You can update the links following the template "https://download.openmmlab.com/mmdetection3d/v1.1.0_models/tr3d/xxx/xxx.log.json", like "https://download.openmmlab.com/mmdetection3d/v1.1.0_models/tr3d/tr3d_1xb16_scannet-3d-18class/tr3d_1xb16_scannet-3d-18class.log.json".

BTW, could you please revise the config folder name from "TR3D" to "tr3d" to make it consistent with others?

@filaPro
Copy link
Contributor Author

filaPro commented Feb 20, 2023

Hi @Tai-Wang ,
Thanks a lot.
But i followed projects directory where all config paths are like PETR/petr or CenterFormer/centerformer. Should i rename TR3D/tr3d to tr3d/tr3d?

@Tai-Wang
Copy link
Member

Tai-Wang commented Feb 20, 2023

Hi @Tai-Wang , Thanks a lot. But i followed projects directory where all config paths are like PETR/petr or CenterFormer/centerformer. Should i rename TR3D/tr3d to tr3d/tr3d?

Sorry, the current name should be ok in projects. Only need to change the config folder name to "tr3d" when we integrate these code into the core codes of mmdet3d.

@ZCMax
Copy link
Collaborator

ZCMax commented Feb 20, 2023

Thanks for your PR, it LGTM for me to be merged into projects

@ZwwWayne ZwwWayne merged commit cbddb7f into open-mmlab:dev-1.x Feb 20, 2023
@filaPro filaPro deleted the tr3d branch February 20, 2023 10:31
xizaoqu pushed a commit to xizaoqu/mmdetection3d that referenced this pull request Mar 15, 2023
* first tr3d commit

* all tr3d files added

* all tr3d is ok

* fix comments

* fix config imports and readme

* fix comments

* update links in readme

* fix lint
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants