Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Add Cylinder3D head #2291

Merged
merged 19 commits into from
Mar 6, 2023
Merged

Conversation

xizaoqu
Copy link
Contributor

@xizaoqu xizaoqu commented Feb 17, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Cylinder3D head

Modification

Add Cylinder3D head

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 46.37% // Head: 46.80% // Increases project coverage by +0.42% 🎉

Coverage data is based on head (ab60a3d) compared to base (d84e081).
Patch coverage: 58.74% of modified lines in pull request are covered.

❗ Current head ab60a3d differs from pull request most recent head 57a0218. Consider uploading reports for the commit 57a0218 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2291      +/-   ##
===========================================
+ Coverage    46.37%   46.80%   +0.42%     
===========================================
  Files          259      264       +5     
  Lines        21390    22119     +729     
  Branches      3379     3484     +105     
===========================================
+ Hits          9919    10352     +433     
- Misses       10827    11105     +278     
- Partials       644      662      +18     
Flag Coverage Δ
unittests 46.80% <58.74%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
mmdet3d/models/detectors/mink_single_stage.py 43.58% <ø> (ø)
mmdet3d/testing/data_utils.py 70.83% <ø> (ø)
mmdet3d/models/voxel_encoders/voxel_encoder.py 38.46% <6.94%> (-12.08%) ⬇️
mmdet3d/models/losses/lovasz_loss.py 16.81% <16.81%> (ø)
...t3d/models/data_preprocessors/data_preprocessor.py 39.10% <17.24%> (-5.05%) ⬇️
mmdet3d/datasets/transforms/formating.py 58.03% <33.33%> (+1.78%) ⬆️
mmdet3d/models/data_preprocessors/voxelize.py 33.92% <33.92%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmdet3d/models/losses/lovasz_loss.py Outdated Show resolved Hide resolved
mmdet3d/models/losses/lovasz_loss.py Outdated Show resolved Hide resolved
mmdet3d/models/losses/lovasz_loss_utils.py Outdated Show resolved Hide resolved
mmdet3d/models/losses/lovasz_loss.py Outdated Show resolved Hide resolved
mmdet3d/models/losses/lovasz_loss.py Outdated Show resolved Hide resolved
mmdet3d/models/losses/lovasz_loss.py Show resolved Hide resolved
@ZwwWayne ZwwWayne requested a review from ZCMax February 23, 2023 05:05
mmdet3d/models/decode_heads/cylinder3d_head.py Outdated Show resolved Hide resolved
mmdet3d/models/decode_heads/cylinder3d_head.py Outdated Show resolved Hide resolved
mmdet3d/models/decode_heads/decode_head.py Outdated Show resolved Hide resolved
mmdet3d/models/losses/lovasz_loss.py Outdated Show resolved Hide resolved
mmdet3d/models/losses/lovasz_loss.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit a1b974a into open-mmlab:dev-1.x Mar 6, 2023
xizaoqu added a commit to xizaoqu/mmdetection3d that referenced this pull request Mar 15, 2023
* add cylinder decode head

* update

* update

* add lovasz loss

* update

* update

* update

* update

* update

* update

* update

* update

* update

* cylinder3d_head

* update

* update

* update

* update
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants