-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Feature] File I/O migration and reconstruction #2319
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2319 +/- ##
===========================================
- Coverage 47.04% 46.86% -0.18%
===========================================
Files 262 264 +2
Lines 22040 22173 +133
Branches 3467 3482 +15
===========================================
+ Hits 10368 10392 +24
- Misses 11006 11118 +112
+ Partials 666 663 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link of the corresponding refactoring in mmengine in PR message.
Please add a PR description about the difference between the usage of backend_args
and that of file_client_args
if they have.
Please check the |
Have checked. |
74b2359
to
9995d0d
Compare
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
The
fileio
module has been refactored in mmengine in #533.The modification can be referred from mmdet #9709.
Modification
file_client_args
has been renamed tobackend_args
, andHardDiskBackend
toLocalBackend
previous:
now:
Usage:
previous:
now:
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist