Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Deprecating old type alias due to new version of numpy #2339

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  • Replace np.int with np.int64
  • Replace np.bool with bool

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Xiangxu-0103 Xiangxu-0103 changed the title [Fix] Deprecating old type alias due to new version of numpyNew type alias [Fix] Deprecating old type alias due to new version of numpy Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 60.50% and project coverage change: +0.50 🎉

Comparison is base (d84e081) 46.37% compared to head (1e2e391) 46.87%.

❗ Current head 1e2e391 differs from pull request most recent head c452bb1. Consider uploading reports for the commit c452bb1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2339      +/-   ##
===========================================
+ Coverage    46.37%   46.87%   +0.50%     
===========================================
  Files          259      264       +5     
  Lines        21390    22193     +803     
  Branches      3379     3491     +112     
===========================================
+ Hits          9919    10403     +484     
- Misses       10827    11124     +297     
- Partials       644      666      +22     
Flag Coverage Δ
unittests 46.87% <60.50%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 78.08% <ø> (ø)
mmdet3d/datasets/scannet_dataset.py 82.75% <ø> (ø)
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
mmdet3d/evaluation/metrics/seg_metric.py 62.50% <0.00%> (ø)
mmdet3d/models/dense_heads/centerpoint_head.py 21.77% <0.00%> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
mmdet3d/models/detectors/mink_single_stage.py 43.58% <ø> (ø)
mmdet3d/testing/data_utils.py 70.83% <ø> (ø)
mmdet3d/models/voxel_encoders/voxel_encoder.py 38.28% <7.14%> (-12.26%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit b2e5ad6 into open-mmlab:dev-1.x Mar 13, 2023
@Xiangxu-0103 Xiangxu-0103 deleted the new_type_alias branch March 15, 2023 06:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants