Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Support MultiModalityDet3DInferencer #2342

Merged
merged 17 commits into from
Mar 28, 2023

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 43.26% and project coverage change: -0.03 ⚠️

Comparison is base (dfcf542) 47.27% compared to head (700548f) 47.24%.

❗ Current head 700548f differs from pull request most recent head 766c89f. Consider uploading reports for the commit 766c89f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2342      +/-   ##
===========================================
- Coverage    47.27%   47.24%   -0.03%     
===========================================
  Files          270      271       +1     
  Lines        22513    22648     +135     
  Branches      3513     3534      +21     
===========================================
+ Hits         10643    10701      +58     
- Misses       11193    11267      +74     
- Partials       677      680       +3     
Flag Coverage Δ
unittests 47.24% <43.26%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/apis/__init__.py 100.00% <ø> (ø)
mmdet3d/apis/inference.py 14.63% <0.00%> (-0.09%) ⬇️
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/visualization/local_visualizer.py 33.78% <0.00%> (-0.23%) ⬇️
mmdet3d/datasets/transforms/loading.py 44.91% <25.58%> (-1.74%) ⬇️
...pis/inferencers/multi_modality_det3d_inferencer.py 52.27% <52.27%> (ø)
mmdet3d/apis/inferencers/lidar_det3d_inferencer.py 56.25% <75.00%> (ø)
mmdet3d/apis/inferencers/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmdet3d/apis/inference.py Outdated Show resolved Hide resolved
@JingweiZhang12 JingweiZhang12 changed the title [Feature] Suuport MultiModalityDet3DInferencer [Feature] Support MultiModalityDet3DInferencer Mar 20, 2023
@JingweiZhang12 JingweiZhang12 requested review from Xiangxu-0103, Tai-Wang and ZCMax and removed request for ZCMax and Xiangxu-0103 March 20, 2023 02:11
Copy link
Collaborator

@Xiangxu-0103 Xiangxu-0103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix minor comments

@JingweiZhang12 JingweiZhang12 removed the request for review from ZCMax March 22, 2023 06:31
@ZwwWayne ZwwWayne merged commit c9fd5a6 into open-mmlab:dev-1.x Mar 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants