Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Cylinder3d segmentor #2344

Merged
merged 11 commits into from
Mar 20, 2023

Conversation

xizaoqu
Copy link
Contributor

@xizaoqu xizaoqu commented Mar 11, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Cylinder3d segmentor.

Modification

Add Cylinder3d segmentor. NOTE: backbone hasn't been merged yet. SemanticKITTI label format hasn't changed yet.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 64.50% and project coverage change: +0.90 🎉

Comparison is base (d84e081) 46.37% compared to head (6484bd4) 47.27%.

❗ Current head 6484bd4 differs from pull request most recent head b1c2df6. Consider uploading reports for the commit b1c2df6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2344      +/-   ##
===========================================
+ Coverage    46.37%   47.27%   +0.90%     
===========================================
  Files          259      266       +7     
  Lines        21390    22383     +993     
  Branches      3379     3489     +110     
===========================================
+ Hits          9919    10582     +663     
- Misses       10827    11129     +302     
- Partials       644      672      +28     
Flag Coverage Δ
unittests 47.27% <64.50%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 78.08% <ø> (ø)
mmdet3d/datasets/scannet_dataset.py 82.75% <ø> (ø)
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/waymo_dataset.py 17.72% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
...tion/functional/waymo_utils/prediction_to_waymo.py 0.00% <0.00%> (ø)
mmdet3d/evaluation/metrics/seg_metric.py 62.50% <0.00%> (ø)
mmdet3d/evaluation/metrics/waymo_metric.py 8.11% <ø> (ø)
mmdet3d/models/dense_heads/centerpoint_head.py 21.77% <0.00%> (ø)
mmdet3d/models/dense_heads/fcaf3d_head.py 16.23% <ø> (ø)
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmdet3d/models/backbones/cylinder3d.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/cylinder3d.py Outdated Show resolved Hide resolved
@sunjiahao1999 sunjiahao1999 self-requested a review March 16, 2023 06:38
configs/cylinder3d/cylinder3d_4xb4_3x_semantickitti.py Outdated Show resolved Hide resolved
mmdet3d/models/segmentors/cylinder3d.py Outdated Show resolved Hide resolved
mmdet3d/models/backbones/cylinder3d.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit dfcf542 into open-mmlab:dev-1.x Mar 20, 2023
@WuYanXingege
Copy link

encounter an error when runing cylinder : assert 'pts_semantic_mask' in results ,error appeared in transform process

@xizaoqu
Copy link
Contributor Author

xizaoqu commented Jun 6, 2023

encounter an error when runing cylinder : assert 'pts_semantic_mask' in results ,error appeared in transform process

What config do you use?

@qpc001
Copy link

qpc001 commented Jun 8, 2023

we need to delete the lines in config file cylinder3d_4xb4-3x_semantickitti.py:
image

@WuYanXingege
Copy link

WuYanXingege commented Jun 8, 2023 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants