Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

centerformer coordinates correspondence of gt box length and width #2362

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

DezeZhao
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Modification

mmdet3d coordinates are xyzlwhr, while in CenterFormer, l and w are opposite. This should be the same as mmdet3d coordinates.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@JingweiZhang12 JingweiZhang12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll appreciate it if you can fix the same problem in CenterPoint

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage: 58.80% and project coverage change: +0.49 🎉

Comparison is base (d84e081) 46.37% compared to head (05a6036) 46.86%.

❗ Current head 05a6036 differs from pull request most recent head 2bf94ff. Consider uploading reports for the commit 2bf94ff to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2362      +/-   ##
===========================================
+ Coverage    46.37%   46.86%   +0.49%     
===========================================
  Files          259      267       +8     
  Lines        21390    22226     +836     
  Branches      3379     3486     +107     
===========================================
+ Hits          9919    10416     +497     
- Misses       10827    11146     +319     
- Partials       644      664      +20     
Flag Coverage Δ
unittests 46.86% <58.80%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 78.08% <ø> (ø)
mmdet3d/datasets/scannet_dataset.py 82.75% <ø> (ø)
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/waymo_dataset.py 17.72% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
...tion/functional/waymo_utils/prediction_to_waymo.py 0.00% <0.00%> (ø)
mmdet3d/evaluation/metrics/instance_seg_metric.py 94.44% <ø> (ø)
mmdet3d/evaluation/metrics/seg_metric.py 62.50% <0.00%> (ø)
mmdet3d/evaluation/metrics/waymo_metric.py 8.11% <0.00%> (ø)
mmdet3d/models/dense_heads/centerpoint_head.py 21.77% <0.00%> (ø)
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit afa4479 into open-mmlab:dev-1.x Mar 20, 2023
@DezeZhao
Copy link
Contributor Author

We'll appreciate it if you can fix the same problem in CenterPoint

OK I will do it later.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants