Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Docs] Add docs and README for SPVCNN #2372

Merged
merged 13 commits into from
Apr 4, 2023

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Add docs and README for SPVCNN.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b481efc) 47.00% compared to head (b0aa33f) 47.00%.

❗ Current head b0aa33f differs from pull request most recent head 972e523. Consider uploading reports for the commit 972e523 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2372   +/-   ##
========================================
  Coverage    47.00%   47.00%           
========================================
  Files          275      275           
  Lines        22898    22898           
  Branches      3565     3565           
========================================
  Hits         10763    10763           
  Misses       11450    11450           
  Partials       685      685           
Flag Coverage Δ
unittests 47.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

configs/spvcnn/README.md Outdated Show resolved Hide resolved
configs/spvcnn/README.md Outdated Show resolved Hide resolved
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need to revise the model/log links

@ZwwWayne ZwwWayne merged commit 6d9be30 into open-mmlab:dev-1.x Apr 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants