Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CI] Loose the version restriction of numba #2416

Merged
merged 7 commits into from
Apr 10, 2023

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The numpy0.53.0 does not support numpy>=1.24.0, so we should use the latest numba.
numba/numba#8691

The reason of using numpy==0.53.0 before

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 54.70% and project coverage change: +0.61 🎉

Comparison is base (d84e081) 46.37% compared to head (aa6c70e) 46.98%.

❗ Current head aa6c70e differs from pull request most recent head d473aa0. Consider uploading reports for the commit d473aa0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2416      +/-   ##
===========================================
+ Coverage    46.37%   46.98%   +0.61%     
===========================================
  Files          259      275      +16     
  Lines        21390    22898    +1508     
  Branches      3379     3565     +186     
===========================================
+ Hits          9919    10759     +840     
- Misses       10827    11454     +627     
- Partials       644      685      +41     
Flag Coverage Δ
unittests 46.98% <54.70%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/s3dis_dataset.py 78.08% <ø> (ø)
mmdet3d/datasets/scannet_dataset.py 82.75% <ø> (ø)
mmdet3d/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmdet3d/datasets/waymo_dataset.py 17.72% <ø> (ø)
mmdet3d/evaluation/__init__.py 100.00% <ø> (ø)
...tion/functional/waymo_utils/prediction_to_waymo.py 0.00% <0.00%> (ø)
mmdet3d/evaluation/metrics/instance_seg_metric.py 94.44% <ø> (ø)
mmdet3d/evaluation/metrics/seg_metric.py 62.50% <0.00%> (ø)
mmdet3d/evaluation/metrics/waymo_metric.py 8.11% <0.00%> (ø)
mmdet3d/models/dense_heads/centerpoint_head.py 21.77% <0.00%> (ø)
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mmdet3d/version.py Outdated Show resolved Hide resolved
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
@ZwwWayne ZwwWayne merged commit ca1355d into open-mmlab:dev-1.x Apr 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants