Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

mmdet3d Docs update for registry location #2442

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

pd-michaelstanley
Copy link
Contributor

Registry docs are now under Advanced Tutorials.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Changed doc location. I was looking for the docs and had to go find them myself.

Modification

Updated the doc link for Registry in mmengine

BC-breaking (Optional)

No, no breaking changes

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Registry docs are now under Advanced Tutorials.
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

@OpenMMLab-Assistant-004

Hi @pd-michaelstanley !We are grateful for your efforts in helping improve mmdetection3d open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

@JingweiZhang12 JingweiZhang12 merged commit 47e56e1 into open-mmlab:main Apr 24, 2023
JingweiZhang12 pushed a commit that referenced this pull request May 10, 2023
* [Docs] Update link of registry tutorial (#2442)

Registry docs are now under Advanced Tutorials.

* update issue template

* update config.yml

---------

Co-authored-by: pd-michaelstanley <88335018+pd-michaelstanley@users.noreply.github.com>
JingweiZhang12 pushed a commit that referenced this pull request May 11, 2023
* [Docs] Update link of registry tutorial (#2442)

Registry docs are now under Advanced Tutorials.

* add typehint to the backbones of model.

* Update typehint with OptMultiConfig and Tensor to torch.Tensor

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dla.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dla.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update mmdet3d/models/backbones/dgcnn.py

Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>

* Update typehint.

* add typehint to function mono_cam_box2vis and remove assert keyword.

* Update typehint.

* Fixed some problems.

---------

Co-authored-by: pd-michaelstanley <88335018+pd-michaelstanley@users.noreply.github.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants