-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Feature] Add task_modules type hint #2485
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2485 +/- ##
===========================================
+ Coverage 46.92% 47.02% +0.10%
===========================================
Files 277 277
Lines 23235 23280 +45
Branches 3622 3622
===========================================
+ Hits 10903 10948 +45
Misses 11641 11641
Partials 691 691
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Thanks for your PR. Please review this PR. @Xiangxu-0103 |
mmdet3d/models/task_modules/samplers/iou_neg_piecewise_sampler.py
Outdated
Show resolved
Hide resolved
mmdet3d/models/task_modules/samplers/iou_neg_piecewise_sampler.py
Outdated
Show resolved
Hide resolved
mmdet3d/models/task_modules/samplers/iou_neg_piecewise_sampler.py
Outdated
Show resolved
Hide resolved
mmdet3d/models/task_modules/samplers/iou_neg_piecewise_sampler.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Co-authored-by: Xiang Xu <xuxiang0103@gmail.com>
Hi @A-new-b , please update this PR according to the comments and fix the lint issue. |
thanks for your reminder, I have fixed the lint |
Motivation
Add task_modules type hint to the code and make it more readable.
Modification
add type hints to mmdet3d/model/task_modules
Checklist