Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature]Add Minkowski block #2528

Merged
merged 7 commits into from
May 19, 2023

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@sunjiahao1999 sunjiahao1999 changed the base branch from main to dev-1.x May 14, 2023 13:22
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 43.47% and project coverage change: -0.01 ⚠️

Comparison is base (65e2832) 46.93% compared to head (ef58b68) 46.92%.

❗ Current head ef58b68 differs from pull request most recent head aa40613. Consider uploading reports for the commit aa40613 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2528      +/-   ##
===========================================
- Coverage    46.93%   46.92%   -0.01%     
===========================================
  Files          276      277       +1     
  Lines        23189    23235      +46     
  Branches      3619     3622       +3     
===========================================
+ Hits         10883    10903      +20     
- Misses       11615    11641      +26     
  Partials       691      691              
Flag Coverage Δ
unittests 46.92% <43.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/layers/minkowski_engine_block.py 42.22% <42.22%> (ø)
mmdet3d/models/layers/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xiangxu-0103
Copy link
Collaborator

We may also need to update mmdet3d/models/layers/__init__.py

@JingweiZhang12 JingweiZhang12 merged commit 6299a1f into open-mmlab:dev-1.x May 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants