Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] AttributeError: 'LineString' object has no attribute 'exterior' #2557

Merged
merged 4 commits into from
May 26, 2023

Conversation

lbin
Copy link
Contributor

@lbin lbin commented May 26, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lbin lbin changed the title Fix bug: AttributeError: 'LineString' object has no attribute 'exterior' [Fix]: AttributeError: 'LineString' object has no attribute 'exterior' May 26, 2023
@lbin lbin changed the title [Fix]: AttributeError: 'LineString' object has no attribute 'exterior' [Fix] AttributeError: 'LineString' object has no attribute 'exterior' May 26, 2023
@JingweiZhang12
Copy link
Contributor

@lbin Thanks for your awesome contribution, and we're excited to invite you to join core developer community of mmdet3d. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID". We will invite you to MMDet3D developer group.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 43.90% and project coverage change: -0.05 ⚠️

Comparison is base (3fa4dc1) 46.92% compared to head (828bbd6) 46.87%.

❗ Current head 828bbd6 differs from pull request most recent head e666e01. Consider uploading reports for the commit e666e01 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2557      +/-   ##
===========================================
- Coverage    46.92%   46.87%   -0.05%     
===========================================
  Files          277      277              
  Lines        23235    23367     +132     
  Branches      3622     3644      +22     
===========================================
+ Hits         10903    10954      +51     
- Misses       11641    11721      +80     
- Partials       691      692       +1     
Flag Coverage Δ
unittests 46.87% <43.90%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/convert_utils.py 0.00% <0.00%> (ø)
mmdet3d/datasets/transforms/transforms_3d.py 39.98% <0.00%> (-0.12%) ⬇️
mmdet3d/models/detectors/point_rcnn.py 64.28% <ø> (ø)
mmdet3d/models/layers/__init__.py 100.00% <ø> (ø)
...det3d/models/task_modules/samplers/pseudosample.py 90.47% <ø> (ø)
mmdet3d/models/backbones/spvcnn_backone.py 14.28% <8.79%> (-1.03%) ⬇️
mmdet3d/models/backbones/minkunet_backbone.py 18.55% <13.63%> (-11.45%) ⬇️
...t3d/models/data_preprocessors/data_preprocessor.py 31.22% <16.66%> (-0.25%) ⬇️
mmdet3d/models/decode_heads/minkunet_head.py 51.85% <50.00%> (+1.85%) ⬆️
mmdet3d/models/backbones/__init__.py 100.00% <100.00%> (ø)
... and 17 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12 JingweiZhang12 merged commit 03d0164 into open-mmlab:dev-1.x May 26, 2023
@lbin lbin deleted the dev-1.x branch May 26, 2023 06:21
@lbin lbin restored the dev-1.x branch May 26, 2023 06:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants