Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Support new config type #2608

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Support pure python-style configuration files in MMEngine. The details could be seen here

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@JingweiZhang12 JingweiZhang12 changed the title [Features] Support new config type [Feature] Support new config type Jun 16, 2023
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8fb2cf6) 46.91% compared to head (09ea9d0) 46.91%.

❗ Current head 09ea9d0 differs from pull request most recent head 956704f. Consider uploading reports for the commit 956704f to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2608   +/-   ##
========================================
  Coverage    46.91%   46.91%           
========================================
  Files          277      277           
  Lines        23387    23387           
  Branches      3645     3645           
========================================
  Hits         10972    10972           
  Misses       11721    11721           
  Partials       694      694           
Flag Coverage Δ
unittests 46.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JingweiZhang12 JingweiZhang12 merged commit 2c13673 into open-mmlab:dev-1.x Jun 19, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant