Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Fix indoor det visualization #2625

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

sunjiahao1999
Copy link
Collaborator

@sunjiahao1999 sunjiahao1999 commented Jun 29, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.
Before
image
After
image

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@sunjiahao1999 sunjiahao1999 requested a review from ZCMax June 29, 2023 10:58
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 23.07% and project coverage change: -0.02 ⚠️

Comparison is base (12e2b7c) 46.79% compared to head (75d8873) 46.78%.

❗ Current head 75d8873 differs from pull request most recent head f518120. Consider uploading reports for the commit f518120 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2625      +/-   ##
===========================================
- Coverage    46.79%   46.78%   -0.02%     
===========================================
  Files          277      277              
  Lines        23472    23480       +8     
  Branches      3659     3660       +1     
===========================================
+ Hits         10983    10984       +1     
- Misses       11793    11802       +9     
+ Partials       696      694       -2     
Flag Coverage Δ
unittests 46.78% <23.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/datasets/transforms/formating.py 58.33% <ø> (ø)
mmdet3d/visualization/local_visualizer.py 25.94% <9.09%> (-0.41%) ⬇️
mmdet3d/__init__.py 100.00% <100.00%> (ø)
mmdet3d/engine/hooks/visualization_hook.py 50.98% <100.00%> (+0.48%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne ZwwWayne merged commit e990105 into open-mmlab:dev-1.x Jul 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants