Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CodeCamp2023-516]Add new configuration files for Cylinder3D #2681

Merged
merged 3 commits into from
Sep 13, 2023
Merged

[CodeCamp2023-516]Add new configuration files for Cylinder3D #2681

merged 3 commits into from
Sep 13, 2023

Conversation

ZhaoCake
Copy link
Contributor

@ZhaoCake ZhaoCake commented Aug 5, 2023

Motivation

Add new configuration files for Cylinder3D

Modification

Add one file in mmdet3d/configs/_base_/models called mmdet3d/configs/_base_/models/cylinder3d.py , and two file in mmdet3d/configs/cylinder3d which used to train and test.

Checklist

  1. Passed Pre-commit.
  2. Finished train and test on A4000-16G, only modify train batchsize to 2 as out of memory and epoch to 1.
  3. The logs and epoch is available here:链接:百度网盘提取码:zee2
  4. If there is anything to correct, please tell me.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 15.44% and project coverage change: -0.14% ⚠️

Comparison is base (3fa0e8b) 46.91% compared to head (3e61c89) 46.78%.
Report is 19 commits behind head on dev-1.x.

❗ Current head 3e61c89 differs from pull request most recent head 9bdacf9. Consider uploading reports for the commit 9bdacf9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2681      +/-   ##
===========================================
- Coverage    46.91%   46.78%   -0.14%     
===========================================
  Files          277      277              
  Lines        23381    23480      +99     
  Branches      3644     3660      +16     
===========================================
+ Hits         10969    10984      +15     
- Misses       11719    11802      +83     
- Partials       693      694       +1     
Flag Coverage Δ
unittests 46.78% <15.44%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mmdet3d/datasets/transforms/formating.py 58.33% <ø> (ø)
mmdet3d/models/necks/second_fpn.py 90.62% <ø> (ø)
mmdet3d/visualization/local_visualizer.py 25.94% <8.33%> (-4.20%) ⬇️
mmdet3d/datasets/transforms/loading.py 44.97% <50.00%> (+0.05%) ⬆️
mmdet3d/engine/hooks/visualization_hook.py 50.98% <71.42%> (+1.50%) ⬆️
mmdet3d/__init__.py 100.00% <100.00%> (ø)
mmdet3d/version.py 61.53% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunjiahao1999
Copy link
Collaborator

sunjiahao1999 commented Aug 10, 2023

LGTM, add a __init__.py in mmdet3d/configs/cylinder3d.

@ZhaoCake
Copy link
Contributor Author

LGTM, add a __init__.py in mmdet3d/configs/cylinder3d.

Thanks for the reminder, sir.

@Tai-Wang Tai-Wang merged commit 6e6edfa into open-mmlab:dev-1.x Sep 13, 2023
1 of 2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants