Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Adjust the minimum supported python version to 3.7 #863

Merged

Conversation

HAOCHENYE
Copy link
Collaborator

@HAOCHENYE HAOCHENYE commented Jan 5, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Adjust the minimum supported python version to 3.7

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@HAOCHENYE HAOCHENYE changed the title [Fix] Prefer install binray for opencv [Fix] Prefer install binray package for opencv Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 78.66% // Head: 78.02% // Decreases project coverage by -0.64% ⚠️

Coverage data is based on head (c2e80ca) compared to base (fe26c65).
Patch coverage: 46.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   78.66%   78.02%   -0.65%     
==========================================
  Files         128      130       +2     
  Lines        9348     9423      +75     
  Branches     1848     1886      +38     
==========================================
- Hits         7354     7352       -2     
- Misses       1679     1752      +73     
- Partials      315      319       +4     
Flag Coverage Δ
unittests 78.02% <46.87%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmengine/model/wrappers/__init__.py 66.66% <ø> (-3.34%) ⬇️
mmengine/optim/optimizer/zero_optimizer.py 52.17% <0.00%> (-4.97%) ⬇️
mmengine/registry/build_functions.py 80.20% <ø> (ø)
mmengine/registry/default_scope.py 100.00% <ø> (ø)
mmengine/runner/runner.py 84.91% <ø> (-0.24%) ⬇️
mmengine/structures/base_data_element.py 93.61% <ø> (-0.04%) ⬇️
mmengine/structures/label_data.py 100.00% <ø> (ø)
mmengine/visualization/vis_backend.py 83.79% <ø> (-0.70%) ⬇️
mmengine/visualization/visualizer.py 93.03% <ø> (-0.17%) ⬇️
mmengine/runner/checkpoint.py 52.07% <14.28%> (+8.11%) ⬆️
... and 51 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HAOCHENYE HAOCHENYE force-pushed the HAOCHENYE/prefer_install_binary branch from 5e2d732 to c26cce7 Compare January 5, 2023 10:45
@zhouzaida zhouzaida merged commit 136b453 into open-mmlab:main Jan 6, 2023
@HAOCHENYE HAOCHENYE changed the title [Fix] Prefer install binray package for opencv [Fix] Adjust the minimum supported python version to 3.6 Jan 6, 2023
@HAOCHENYE HAOCHENYE changed the title [Fix] Adjust the minimum supported python version to 3.6 [Fix] Adjust the minimum supported python version to 3.7 Jan 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants