-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Refactor] Refactor single and multi label metrics #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C1rN09
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good! Please also modify the api docs && support_matrix documentation.
264a1fd
to
bbddefd
Compare
C1rN09
reviewed
Feb 16, 2023
C1rN09
reviewed
Feb 17, 2023
C1rN09
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 1 comments!
6b29de6
to
4b19cfc
Compare
C1rN09
reviewed
Mar 8, 2023
4b19cfc
to
540633b
Compare
zhouzaida
approved these changes
Mar 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of
SingleLabelMetric
andMultiLabelMetric
Motivation
The class name is not apparent for user to know its function.
Modification
SingleLabelPrecsionRecallF1score
andMultiLabelPrecsionRecallF1score
PrecsionRecallF1score
with an extratask
argument for direct usage to create different instance.Use cases (Optional)
Checklist