Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] eval hook resume best acc #33

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

linyq17
Copy link
Collaborator

@linyq17 linyq17 commented Dec 30, 2021

Modification

  1. Resume the best accuracy from the checkpoint in eval hook. --resume-from ignores last best accuracy #30
  2. Make eval hook run before checkpoint saver hook by changing the priority to 45.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #33 (132250a) into main (f524344) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 132250a differs from pull request most recent head 624bce6. Consider uploading reports for the commit 624bce6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   60.40%   60.44%   +0.04%     
==========================================
  Files         116      116              
  Lines        7397     7400       +3     
  Branches     1458     1459       +1     
==========================================
+ Hits         4468     4473       +5     
  Misses       2610     2610              
+ Partials      319      317       -2     
Flag Coverage Δ
unittests 60.40% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmfewshot/classification/apis/train.py 18.33% <ø> (ø)
...wshot/classification/core/evaluation/eval_hooks.py 77.90% <100.00%> (+3.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f524344...624bce6. Read the comment docs.

@linyq17 linyq17 closed this Dec 30, 2021
@linyq17 linyq17 reopened this Dec 30, 2021
Copy link
Collaborator

@jshilong jshilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants