Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Enhancement]Revise collect_env for win platform #112

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

MeowZheng
Copy link
Collaborator

Modification

  1. Add try-except block when checking gcc version for Windows platform

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #112 (9d6a85c) into master (413553e) will increase coverage by 0.26%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   68.45%   68.71%   +0.26%     
==========================================
  Files          89       91       +2     
  Lines        4999     5022      +23     
  Branches      713      716       +3     
==========================================
+ Hits         3422     3451      +29     
+ Misses       1468     1459       -9     
- Partials      109      112       +3     
Flag Coverage Δ
unittests 68.71% <66.66%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/utils/collect_env.py 53.44% <66.66%> (+33.44%) ⬆️
mmflow/datasets/pipelines/transforms.py 77.50% <0.00%> (-0.67%) ⬇️
mmflow/datasets/builder.py 87.50% <0.00%> (ø)
mmflow/core/utils/__init__.py 100.00% <0.00%> (ø)
mmflow/core/utils/dist_utils.py 56.25% <0.00%> (ø)
mmflow/datasets/samplers/distributed_sampler.py 53.01% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413553e...9d6a85c. Read the comment docs.

@MeowZheng MeowZheng changed the title Revise collect_env for win platform [Enhancement]Revise collect_env for win platform Mar 28, 2022
@MeowZheng MeowZheng merged commit a8ee90e into open-mmlab:master Mar 29, 2022
@MeowZheng MeowZheng deleted the os_win branch March 29, 2022 02:48
MeowZheng added a commit that referenced this pull request Jul 15, 2022
* Revise collect_env for win platform

* add ut

* fix ut

* remove win ut
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant