the the typo error of function name sample_unconditional_model
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the typo
fix the typo error
fix the typo
fix the typo error
fix the typo error
fix the typo error
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 76.71% 76.75% +0.04%
==========================================
Files 130 130
Lines 9421 9421
Branches 1899 1899
==========================================
+ Hits 7227 7231 +4
+ Misses 1728 1726 -2
+ Partials 466 464 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks for your contribution. Please run |
plyfager
reviewed
Jan 17, 2022
| @@ -65,7 +65,7 @@ def main(): | |||
| if args.sample_cfg is None: | |||
| args.sample_cfg = dict() | |||
|
|
|||
| results = sample_uncoditional_model(model, args.num_samples, | |||
| results = sample_unconditional_model(model, args.num_samples, | |||
There was a problem hiding this comment.
You may also fix the api name here.
mmgeneration/demo/unconditional_demo.py
Line 12 in e1212d5
|
Since this has been implemented in #249 , this pr will be closed. |
LeoXing1996
pushed a commit
to LeoXing1996/mmgeneration
that referenced
this pull request
Oct 27, 2022
* Add LIIF. * Add LIIF. * modify super init. * Add licence,optimize code. * remove debugging codes. * Modify __init__() function. * Modify test function of LIIF. Co-authored-by: 李尹硕 <SENSETIME\liyinshuo@cn0014004493l.domain.sensetime.com> Co-authored-by: liyinshuo <liyinshuo@sensetime.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_uncoditional_model --> sample_unconditional_model