-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Enhance] Refine body3d_two_stage_video_demo.py #1490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1490 +/- ##
==========================================
- Coverage 84.47% 84.45% -0.02%
==========================================
Files 236 236
Lines 20036 20038 +2
Branches 3602 3603 +1
==========================================
- Hits 16925 16923 -2
- Misses 2231 2233 +2
- Partials 880 882 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
else: | ||
raise NotImplementedError | ||
keypoints_new = np.zeros((17, keypoints.shape[1]), dtype=keypoints.dtype) | ||
if pose_lift_dataset == 'Body3DH36MDataset': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use dataset_info in https://github.com/open-mmlab/mmpose/tree/master/configs/_base_/datasets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the keypoint indexes conversion is hard to use the info in dataset_info
. We may consider adding a tool to convert the keypoint orders later.
Motivation
Inrich the keypoint conversions from pose_lift_dataset to pose_det_dataset.
Now, the demo support the following conversions:
Body3DH36MDataset
to['TopDownCocoDataset', 'TopDownPoseTrack18Dataset', 'TopDownPoseTrack18VideoDataset', 'TopDownAicDataset'], ['TopDownCrowdPoseDataset']
;Body3DMpiInf3dhpDataset
to['TopDownCocoDataset', 'TopDownPoseTrack18Dataset', 'TopDownPoseTrack18VideoDataset', 'TopDownAicDataset'], ['TopDownCrowdPoseDataset']
;Fix the problem mentioned in #1485.
Credit to @pallgeuer.
Modification
BC-breaking (Optional)
Use cases (Optional)
A command to run the demo using the 1-frame videopose3d model trained on
Body3DMpiInf3dhpDataset
:Checklist
Before PR:
After PR: