Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Avoid mapping unnecessary key to albu format #1716

Closed
wants to merge 28 commits into from

Conversation

liqikai9
Copy link
Collaborator

Motivation

img_v2_2b7b0727-de34-4743-b7cb-1b6091936e8g

The original results of data info may contain the key like keypoints which may trigger unexpected functions and raise error in albu like apply_to_keypoint.

Modification

Modify mmpose/datasets/transforms/common_transforms.py, only map those keys that are specified in keymap_to_albu to albu format.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

ly015 and others added 26 commits September 13, 2022 19:21
* add associative embedding codec

* refactor decoding [wip]

* refactor decoding process

* add associative embedding codec

* refactor decoding refinements

* add missing keypoint complement and unit test

* support dynamic input_size in decoding

* add unit test for decoding with dynamic size
* [Doc] Refine installation docs

* modify installation verification

* fix links in readme

* fix typos in demo

* fix demo results

* fix demo image

* refine some docs

* update links

* fix overview image

Co-authored-by: lupeng <penglu2097@gmail.com>
…1668)

* fix visualizer's dataset_meta error in visualization_hook with multiple GPUs

* refine dataset browser

* use string typehint for compatibility with python3.6

* update unittest for visualizer and visulization_hook

* refine visualizer to avoid saving duplicated images with visualization_hook

* refine dataset browser
* refine demo and visualization

* refine topdown face demo

* resolve comments

* fix keypoint and skeleton transparency

Co-authored-by: lupeng <penglu2097@gmail.com>
…b#1627)

Co-authored-by: Qikai Li <87690686+liqikai9@users.noreply.github.com>
* update algorithm readme with performance tables

* resolve comments
@liqikai9 liqikai9 requested a review from Tau-J October 13, 2022 03:44
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 77.76% // Head: 77.76% // No change to project coverage 👍

Coverage data is based on head (44a21f7) compared to base (44a21f7).
Patch has no changes to coverable lines.

❗ Current head 44a21f7 differs from pull request most recent head aafc17f. Consider uploading reports for the commit aafc17f to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1716   +/-   ##
========================================
  Coverage    77.76%   77.76%           
========================================
  Files          204      204           
  Lines        11712    11712           
  Branches      1953     1953           
========================================
  Hits          9108     9108           
  Misses        2205     2205           
  Partials       399      399           
Flag Coverage Δ
unittests 77.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015
Copy link
Member

ly015 commented Oct 13, 2022

CI failed. Please check it.

* specify mmengine version

* fix denpendency version
@ly015
Copy link
Member

ly015 commented Oct 13, 2022

#1715 has been merged which fixes the CI issue. Please rebase onto dev-1.x

@liqikai9
Copy link
Collaborator Author

#1715 has been merged which fixes the CI issue. Please rebase onto dev-1.x

Done

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants