Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Fix webcam metainfo #1813

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

Ben-Louis
Copy link
Collaborator

Motivation

The metainfo item 'CLASSES' in MMPose has a different format from that in MMDectection. This conflict will lead to an error illustrated in #1812.

Modification

In TopDownPoseEstimatorNode, use the values from detector metainfo for overlapped keys instead of the values from pose estimator metainfo.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Ben-Louis Ben-Louis mentioned this pull request Nov 17, 2022
@ly015 ly015 changed the base branch from dev-1.x to 1.x November 18, 2022 06:02
@ly015 ly015 changed the base branch from 1.x to dev-1.x November 18, 2022 06:12
@ly015 ly015 merged commit ec54643 into open-mmlab:dev-1.x Nov 18, 2022
@Ben-Louis Ben-Louis deleted the fix-webcam-metainfo branch December 13, 2022 05:33
ly015 pushed a commit to ly015/mmpose that referenced this pull request Feb 21, 2023
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants