Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] fix warnings when falling back to mmengine registry #2082

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Mar 17, 2023

Motivation

This PR fixes the warnings raised when falling back to mmengine registries (registries without registered modules in mmpose).

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (3157208) 81.77% compared to head (1c50e77) 81.85%.

❗ Current head 1c50e77 differs from pull request most recent head 358d71a. Consider uploading reports for the commit 358d71a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2082      +/-   ##
===========================================
+ Coverage    81.77%   81.85%   +0.07%     
===========================================
  Files          227      227              
  Lines        13446    13447       +1     
  Branches      2286     2286              
===========================================
+ Hits         10996    11007      +11     
+ Misses        1933     1924       -9     
+ Partials       517      516       -1     
Flag Coverage Δ
unittests 81.85% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/registry.py 100.00% <ø> (ø)
mmpose/engine/__init__.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 merged commit 3de2327 into open-mmlab:dev-1.x Mar 17, 2023
@ly015 ly015 deleted the fix-registry-warning branch March 17, 2023 05:11
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants