Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Add diff seeds to diff ranks #102

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Mar 10, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add diff seeds to diff ranks. Refer to https://github.com/open-mmlab/mmselfsup/pull/228/files

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 changed the base branch from main to dev March 10, 2022 13:13
Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #102 (2df7a47) into dev (077ae5d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #102      +/-   ##
==========================================
- Coverage   28.96%   28.94%   -0.02%     
==========================================
  Files         104      104              
  Lines        6581     6581              
  Branches      985      985              
==========================================
- Hits         1906     1905       -1     
  Misses       4609     4609              
- Partials       66       67       +1     
Flag Coverage Δ
unittests 28.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/builder.py 48.14% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077ae5d...2df7a47. Read the comment docs.

@ZwwWayne ZwwWayne merged commit f5da6f2 into open-mmlab:dev Mar 17, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants