Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] 'RoIAlignRotated' object has no attribute 'output_size' #213

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Apr 13, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Resolve #167

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #213 (739908a) into main (44b0aec) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   28.30%   28.30%   -0.01%     
==========================================
  Files         108      108              
  Lines        6967     6968       +1     
  Branches     1048     1048              
==========================================
  Hits         1972     1972              
- Misses       4927     4928       +1     
  Partials       68       68              
Flag Coverage Δ
unittests 28.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oi_extractors/rotate_single_level_roi_extractor.py 23.07% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b0aec...739908a. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 382c06d into open-mmlab:main Apr 20, 2022
@zytx121 zytx121 mentioned this pull request Apr 28, 2022
ZwwWayne added a commit that referenced this pull request Apr 29, 2022
* [Docs] Update the introduction of SASM (AAAI'22) (#184)

* [Docs] Update the introduction of SASM (AAAI'22)

* Update citation

* [Fix] 'RoIAlignRotated' object has no attribute 'output_size' (#213)

* Update rotate_single_level_roi_extractor.py

* Update rotate_single_level_roi_extractor.py

* [Fix] Fix bug in rotated_reppoints_head

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Co-authored-by: Yue Zhou <592267829@qq.com>
ZwwWayne added a commit that referenced this pull request May 18, 2022
* [Docs] Update the introduction of SASM (AAAI'22) (#184)

* [Docs] Update the introduction of SASM (AAAI'22)

* Update citation

* [Fix] 'RoIAlignRotated' object has no attribute 'output_size' (#213)

* Update rotate_single_level_roi_extractor.py

* Update rotate_single_level_roi_extractor.py

* [Fix]  Modify the use of rotated anchor inside flags (#197)

* rotated RPN bug

* Modify the use of rotated anchor inside flags

* Added PolyDiscreteRotate transform and fixed typos

* Added unit test for PolyDiscreteRotate

* Fixed linting of pipelines __init__

* Fused the 2 transforms

* [Enhance] Support mask in merge_results and huge_image_demo.py. (#280)

* Support masks mergeing

* Update error report

* Added mode argument

* Fixed redundancy and added value unit test

Co-authored-by: Wenwei Zhang <40779233+ZwwWayne@users.noreply.github.com>
Co-authored-by: yangxue <yangxue0827@126.com>
Co-authored-by: Yue Zhou <592267829@qq.com>
Co-authored-by: GamblerZSY <86358394+GamblerZSY@users.noreply.github.com>
Co-authored-by: jbwang1997 <jbwang1997@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants