[DEBUG] Temporary fix for issue "'RoIAlignRotated' object has no attribute 'out_size'" #40 #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Debug for issue #40
Modification
Since
RiRoIAlignRotated
object does not have attributeoutput_size
butout_size
, and vice versa for other RoI inmmcv
.-> Check if object is
RiRoIAlignRotated
then getout_size
attribute, if not getoutput_size
BC-breaking (Optional)
This change make code work without changing downstream repo (
mmcv
), however I think better to update downstreammmcv
repo; specifically in https://github.com/open-mmlab/mmcv/blob/fd3a1a16ea1d0b3def8719816007a5d6fd6b432e/mmcv/ops/riroi_align_rotated.py#L121=>
self.out_size
toself.output_size
Use cases (Optional)
If this PR is for debugging #40