Skip to content

[Enhancement]Revise docstring and UT for layer decay LR #1540

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mmseg/core/optimizers/layer_decay_optimizer_constructor.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def get_layer_id_for_convnext(var_name, max_layer_id):
max_layer_id (int): Maximum number of backbone layers.

Returns:
int: The id number corresponding to different learning rate in
int: The id number corresponding to different learning rate in
``LearningRateDecayOptimizerConstructor``.
"""

Expand Down Expand Up @@ -60,7 +60,7 @@ def get_stage_id_for_convnext(var_name, max_stage_id):
max_stage_id (int): Maximum number of backbone layers.

Returns:
int: The id number corresponding to different learning rate in
int: The id number corresponding to different learning rate in
``LearningRateDecayOptimizerConstructor``.
"""

Expand Down Expand Up @@ -103,8 +103,8 @@ def get_layer_id_for_vit(var_name, max_layer_id):
class LearningRateDecayOptimizerConstructor(DefaultOptimizerConstructor):
"""Different learning rates are set for different layers of backbone.

Note: Currently, this optimizer constructor is built for ConvNeXt
and BEiT.
Note: Currently, this optimizer constructor is built for ConvNeXt,
BEiT and MAE.
"""

def add_params(self, params, module, **kwargs):
Expand Down
24 changes: 24 additions & 0 deletions tests/test_core/test_layer_decay_optimizer_constructor.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,19 @@ def __init__(self):
self.layers.append(layer)


class ToyMAE(nn.Module):

def __init__(self):
super().__init__()
# add some variables to meet unit test coverate rate
self.cls_token = nn.Parameter(torch.ones(1))
self.patch_embed = nn.Parameter(torch.ones(1))
self.layers = nn.ModuleList()
for _ in range(3):
layer = nn.Conv2d(3, 3, 1)
self.layers.append(layer)


class ToySegmentor(nn.Module):

def __init__(self, backbone):
Expand Down Expand Up @@ -236,6 +249,17 @@ def test_learning_rate_decay_optimizer_constructor():
optimizer_cfg, stagewise_paramwise_cfg)
optimizer = optim_constructor(model)

# Test lr wd for MAE
backbone = ToyMAE()
model = PseudoDataParallel(ToySegmentor(backbone))

layerwise_paramwise_cfg = dict(
decay_rate=decay_rate, decay_type='layer_wise', num_layers=3)
optim_constructor = LearningRateDecayOptimizerConstructor(
optimizer_cfg, layerwise_paramwise_cfg)
optimizer = optim_constructor(model)
check_optimizer_lr_wd(optimizer, expected_layer_wise_wd_lr_beit)


def test_beit_layer_decay_optimizer_constructor():

Expand Down