Skip to content

[Bug fix] Fix efficient test for multi-node #707

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

xvjiarui
Copy link
Collaborator

Fixed #706

@xvjiarui xvjiarui requested a review from Junjun2016 July 15, 2021 05:39
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #707 (48f8129) into master (e610ed1) will increase coverage by 0.59%.
The diff coverage is 20.00%.

❗ Current head 48f8129 differs from pull request most recent head 0539678. Consider uploading reports for the commit 0539678 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   85.18%   85.78%   +0.59%     
==========================================
  Files         105      105              
  Lines        5671     5627      -44     
  Branches      923      915       -8     
==========================================
- Hits         4831     4827       -4     
+ Misses        662      621      -41     
- Partials      178      179       +1     
Flag Coverage Δ
unittests 85.76% <20.00%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/test.py 30.66% <20.00%> (+7.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e610ed1...0539678. Read the comment docs.

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!
Tested with multi-gpu with single node and multi-node.

@@ -50,6 +50,8 @@ def single_gpu_test(model,
opacity(float): Opacity of painted segmentation map.
Default 0.5.
Must be in (0, 1] range.
tmpdir (str): Path of directory to save the temporary results for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used.

@xvjiarui xvjiarui merged commit 5097d55 into open-mmlab:master Jul 15, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* [Bug fix] Fix efficient test for multi-node

* fixed CI

* add efficient test dir

* remove unused args
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
* resolve comments

* update changelog

* change the style of 3rdparty
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors occur when using “efficient_test= True”
2 participants