Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change sklearn to scikit-learn in requirements #583

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Change sklearn to scikit-learn in requirements #583

merged 1 commit into from
Nov 18, 2022

Conversation

bencwallace
Copy link

Motivation

The correct package name for scikit-learn is scikit-learn, not sklearn (see the sklearn entry on PyPI).

Modification

This PR changes the sklearn requirement to scikit-learn.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@YuanLiuuuuuu YuanLiuuuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint

@YuanLiuuuuuu YuanLiuuuuuu merged commit d11d3dc into open-mmlab:master Nov 18, 2022
@OpenMMLab-Assistant001
Copy link

Hi @bencwallace

First of all, we want to express our gratitude for your significant PR in the MMSelfsup project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants