Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

pmix: do not include automatically generated include/private/autogen/… #927

Merged
merged 2 commits into from
Feb 4, 2016

Conversation

ggouaillardet
Copy link
Contributor

…config.h into dist tarball

Thanks Siegmar Gross for the initial report of this issue

(back-ported from commit open-mpi/ompi@73daf58)

…config.h into dist tarball

Thanks Siegmar Gross for the initial report of this issue

(back-ported from commit open-mpi/ompi@73daf58)
@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1271/ for details.

@ggouaillardet
Copy link
Contributor Author

:bot:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1270/ for details.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1272/ for details.

@jsquyres
Copy link
Member

@ggouaillardet Can you please set the labels and milestones on PRs? Thanks.

Also, this PR should probably be filed with pmix upstream, as well (if you haven't already done so).

@jsquyres jsquyres added the bug label Jan 27, 2016
@jsquyres jsquyres added this to the v2.0.0 milestone Jan 27, 2016
@ggouaillardet
Copy link
Contributor Author

:bot:assign: @rhc54

upstream pmix has already been updated

@rhc54
Copy link

rhc54 commented Jan 27, 2016

@ggouaillardet @jsquyres This PR is not correct. I had to make a change when we upstreamed it as it broke the upstream tarball creation. I would suggest that we pull the change from there.

👎

@ggouaillardet
Copy link
Contributor Author

ok, I will update ompi master first, and then update this pr with both commits

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1273/ for details.

@ggouaillardet
Copy link
Contributor Author

:bot:nolabel:pushed-back

@rhc54 done, i back-ported the changes from upstream pmix

@jsquyres
Copy link
Member

jsquyres commented Feb 1, 2016

@rhc54 Look ok?

@hppritcha
Copy link
Member

travis red mark is attributed to github being down.

@rhc54
Copy link

rhc54 commented Feb 2, 2016

👍

@hppritcha
Copy link
Member

I think this travis error can be ignored. Looks like something didn't install right on the container that prevents usnic provider from building during the libfabric build.
@jsquyres modulo the travis build failure, I think this is ready to go.

jsquyres added a commit that referenced this pull request Feb 4, 2016
pmix: do not include automatically generated include/private/autogen/…
@jsquyres jsquyres merged commit bfbafee into open-mpi:v2.x Feb 4, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants