Upgrade constraint framework, enabling multi-source constraints #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Smythe <smythe@google.com>
Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe
force-pushed
the
add-multi-src-cts
branch
from
c5fbe38 to
3462571
Compare
ritazh
reviewed
Oct 22, 2019
| @@ -242,7 +242,7 @@ anyrule[}}}//invalid//rego | |||
| if len(status.Errors) != 1 { | |||
| return errors.New("InvalidRego template should contain 1 parse error") | |||
| } else { | |||
| if status.Errors[0].Code != "create_error" { | |||
| if status.Errors[0].Code != "rego_parse_error" { | |||
There was a problem hiding this comment.
Surprised this test has been passing
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Max Smythe smythe@google.com