Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: adding pod subresources in mutation rules #3426

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@JaydipGabani JaydipGabani requested a review from a team as a code owner June 19, 2024 20:36
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.75%. Comparing base (3350319) to head (dcdc5f6).
Report is 84 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (dcdc5f6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (dcdc5f6)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3426      +/-   ##
==========================================
- Coverage   54.49%   46.75%   -7.75%     
==========================================
  Files         134      218      +84     
  Lines       12329    14784    +2455     
==========================================
+ Hits         6719     6912     +193     
- Misses       5116     7070    +1954     
- Partials      494      802     +308     
Flag Coverage Δ
unittests 46.75% <ø> (-7.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 547e2c4 into open-policy-agent:master Jul 2, 2024
20 checks passed
@JaydipGabani JaydipGabani deleted the mutate-subresources branch July 2, 2024 00:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants