Enable connection message logging in debug mode #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enabled when developing the extension. MessageStrategy is a handy place to hook into with logs and a debugger when inspecting the messages between the client and server. I thought this was a sensible default. Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
commented
Apr 10, 2024
| @@ -143,6 +157,9 @@ export function activateRegal(_context: ExtensionContext) { | |||
| outputChannel: outChan, | |||
| traceOutputChannel: outChan, | |||
| revealOutputChannelOn: 0, | |||
| connectionOptions: { | |||
| messageStrategy: new debuggableMessageStrategy, | |||
There was a problem hiding this comment.
I was mainly keen to have something here so that we had it as bookmark so to speak. As it took me some time work out that this was an option and did what I thought it did.
anderseknert
approved these changes
Apr 10, 2024
src/ls/clients/regal.ts
Outdated
| // we can log the messages to the console for debugging purposes. | ||
| if (process.env.VSCODE_DEBUG_MODE === 'true') { | ||
| const messageData = JSON.parse(JSON.stringify(message)); | ||
| const method = messageData.method !== undefined ? messageData.method : 'response'; |
There was a problem hiding this comment.
const method = messageData.method || 'response'; or does that not work in typescript? :)
There was a problem hiding this comment.
Ahh, that does work. I'll use that.
Signed-off-by: Charlie Egan <charlie@styra.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is enabled when developing the extension. MessageStrategy is a handy place to hook into with logs and a debugger when inspecting the messages between the client and server.
I thought this was a sensible default.