fmt/goto-defn: drop functionality in favor of LSP implementation #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to standardize Rego developer env functionality on the Regal LS implementation to be able to offer a standardized experience to all Rego developers, regardless of their preferred editor. Fmt on save and goto definition are now available as part of the language server and so should be accessed via that route instead. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
force-pushed
the
drop-lsp-functionality
branch
from
12c73ee to
eff41e0
Compare
anderseknert
approved these changes
Apr 22, 2024
|
Yeah that makes sense, will do tomorrow. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to standardize Rego developer env functionality on the Regal LS implementation to be able to offer a standardized experience to all Rego developers, regardless of their preferred editor.
Fmt on save and goto definition are now available as part of the language server and so should be accessed via that route instead.