Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop CircleCI and switch to GitHub Actions #120

Merged
merged 7 commits into from
Aug 23, 2024
Merged

Drop CircleCI and switch to GitHub Actions #120

merged 7 commits into from
Aug 23, 2024

Conversation

pi-314159
Copy link
Member

The title says it all.

@pi-314159 pi-314159 requested a review from baentsch August 22, 2024 07:30
@pi-314159 pi-314159 linked an issue Aug 22, 2024 that may be closed by this pull request
Signed-off-by: PI <74706004+pi-314159@users.noreply.github.com>
Signed-off-by: PI <74706004+pi-314159@users.noreply.github.com>
@pi-314159
Copy link
Member Author

pi-314159 commented Aug 22, 2024

@baentsch GHCI passed! Could you remove circleci from this repo? I don't have access to settings of this repo.

p.s. We run this task on a schedule to detect issues early, as updates to dependencies such as libunwind and Go can result in build failures.

@baentsch
Copy link
Member

Thanks for this improvement!

@baentsch GHCI passed! Could you remove circleci from this repo? I don't have access to settings of this repo.

I'd love (and even know how :) to but Sorry, this seems to be yet another area where LF removed permissions when they took ownership of OQS effectively neutering me/relegating me to be "maintainer in name only"; apparently another line item for open-quantum-safe/tsc#45, @dstebila

image

Tagging @ryjones to consider clicking the "Stop Building" button above.

Signed-off-by: PI <74706004+pi-314159@users.noreply.github.com>
@pi-314159 pi-314159 requested a review from baentsch August 22, 2024 09:38
@pi-314159 pi-314159 requested a review from baentsch August 22, 2024 09:42
Signed-off-by: PI <74706004+pi-314159@users.noreply.github.com>
Signed-off-by: PI <74706004+pi-314159@users.noreply.github.com>
Signed-off-by: PI <74706004+pi-314159@users.noreply.github.com>
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this move off CCI!

@pi-314159 pi-314159 merged commit 4aa5d07 into open-quantum-safe:master Aug 23, 2024
3 of 4 checks passed
@pi-314159 pi-314159 deleted the 2024-08-GitHub-CI branch August 23, 2024 07:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to GH CI
2 participants