Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should ship a pkg-config file #1434

Closed
clausecker opened this issue Apr 16, 2023 · 3 comments · Fixed by #1435
Closed

Should ship a pkg-config file #1434

clausecker opened this issue Apr 16, 2023 · 3 comments · Fixed by #1435

Comments

@clausecker
Copy link

Your Rust bindings currently ship a static copy of liboqs. For shipping Rust binaries based on liboqs with unbundled libraries in package managers, we need the Rust bindings to be able to unbundle liboqs. The maintainers of the Rust bindings told me that this is made difficult as liboqs does not ship a pkg-config file: open-quantum-safe/liboqs-rust#190

Perhaps you could ship such a file?

@dstebila
Copy link
Member

I don't think any of us have experience working with pkg-config so we wouldn't know what to create nor how to test it. Are you able to prepare something?

@clausecker
Copy link
Author

Unfortunately I don't know cmake well enough to have an immediate answer to your question.

@tranzystorekk
Copy link
Contributor

Just created a draft pkgconfig PR, should provide something to start off with, but I'll gladly accept any feedback as a first-time contributor to this project.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants