-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Generate and install pkgconfig file #1435
Conversation
Some notes:
|
src/liboqs.pc.in
Outdated
Name: @PROJECT_NAME@ | ||
Description: Library for quantum-safe cryptographic algorithms | ||
Version: @OQS_VERSION_TEXT@ | ||
Requires.private: openssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
liboqs
often requires openssl, but this is optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this would be best solved with an internal variable that is set to "openssl" if OQS_USE_OPENSSL
is enabled. Is there some cmake variable naming convention in this project, e.g. _oqs_pkgconfig_requires_private
?
oops, I only intended to leave a comment, I don't have any experience with |
d80ea39
to
0ccd1f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
@dstebila Now that liboqs has a pkgconfig file, can we create a minor release so that this becomes available in the distros? |
@wucke13 oqsprovider is also waiting for such release. But then again, there's only a single issue requiring resolution for 0.8.0 milestone... Further eyes welcome to help resolve this. |
Adds a basic pkgconfig file generation. The main motivation for this is to enable linking a system-provided liboqs library in liboqs-rust.
I have done a simple manual test by creating a Void Linux package template for liboqs, installing it and checking that pkg-config detects its presence.
I am not proficient in pkgconfig, but I tried to follow the style found in some existing C libraries.
Closes #1434