-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove Rainbow level 1 #1263
Remove Rainbow level 1 #1263
Conversation
@baentsch Should I have also changed RainbowIII and RainbowV to have security level 1 and 3? Within liboqs that should have no effect other than to change some documentation and an information member variable. But will that cause downstream consumers to change the things they pair Rainbow with in hybrid modes? Since the Rainbow team downgraded their claimed security of Rainbow, it would be preferable to have that reflected here, but I don't want to have to go through the process of reassigning everything downstream only for us to remove it a few weeks later. I think we discussed this earlier but I can't remember the decision. |
That was part of the discussion here and there you stated
As you closed the issue there that contained all those steps with all the knock-on effects discussed there (new OIDs, etcpp), my take is "No": Lots of work for an algorithm that's broken and was not part of the NIST competition at those reduced levels. It was dropped (at the original levels). It never was nor ever will be used by anyone at those reduced levels. Thus, changing the Rainbow sec levels doesn't make any sense. Dropping the whole family would have been the most logical solution. Dropping RainbowI is an understandable "bare minimum" and that's what I understood this PR is about (assuming you'd reached agreement on this "bare minimum solution" in last week's call that I couldn't attend). |
@dstebila In the future, please avoid merging such a change to |
Sorry, will try to remember for next time. |
Fixes #1260