Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

once OSSL init #1469

Merged
merged 1 commit into from
May 17, 2023
Merged

once OSSL init #1469

merged 1 commit into from
May 17, 2023

Conversation

baentsch
Copy link
Member

Straw man proposal for improving #1463.

  • [no] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [no] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@baentsch baentsch mentioned this pull request May 17, 2023
Closed
@baentsch baentsch marked this pull request as ready for review May 17, 2023 12:24
@baentsch baentsch requested a review from dstebila as a code owner May 17, 2023 12:24
@baentsch baentsch merged commit 5f5eee8 into main May 17, 2023
@baentsch baentsch deleted the mb-init-once branch May 17, 2023 12:58
paulidale
paulidale reviewed May 17, 2023
View reviewed changes
Copy link

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good solution IMO.
We rely on the run once heavily throughout OpenSSL.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@paulidale paulidale paulidale left review comments

@beldmit beldmit beldmit left review comments

@t8m t8m t8m left review comments

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baentsch @t8m @dstebila @beldmit @paulidale