Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

protect ossl cleanup from multithreading errors #1472

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

baentsch
Copy link
Member

Fixes #1471

  • [no] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [no] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@baentsch baentsch added this to the 0.8.0 milestone May 18, 2023
@baentsch
Copy link
Member Author

@dstebila CI seems to pass, so setting this to Ready for Review as I log off finally for the day. This needs to be in the release.
@beldmit: I now see why you were wary about threading... :-/ Would be glad if you'd also take a look whether this is OK/better.

@baentsch baentsch marked this pull request as ready for review May 18, 2023 17:00
@baentsch baentsch requested a review from dstebila as a code owner May 18, 2023 17:00
@beldmit
Copy link
Contributor

beldmit commented May 18, 2023

LGTM. Do you have any multithreading tests?

@dstebila dstebila merged commit aaa5695 into main May 18, 2023
@dstebila dstebila deleted the mb-ossl-shutdownfix branch May 18, 2023 21:22
@baentsch
Copy link
Member Author

LGTM. Do you have any multithreading tests?

Excellent question. AFAIK No. Created #1474 to track/improve.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threading bug
3 participants