Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Correct cmake version requirement #1643

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Correct cmake version requirement #1643

merged 2 commits into from
Jan 4, 2024

Conversation

baentsch
Copy link
Member

Provides explanation for #1642 and documents minimal cmake version for objects list in generator expression. Also explains the need for open-quantum-safe/ci-containers#68.

  • [no] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [no] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@baentsch baentsch marked this pull request as ready for review December 25, 2023 17:25
@baentsch baentsch requested a review from dstebila as a code owner December 25, 2023 17:25
@baentsch baentsch requested review from bhess and SWilson4 December 25, 2023 17:25
@baentsch baentsch merged commit ed86578 into main Jan 4, 2024
56 checks passed
@baentsch baentsch deleted the mb-cmakeupgrade branch January 4, 2024 10:05
trigpolynom pushed a commit to BytesLogik/liboqs that referenced this pull request Jan 13, 2024
* upgrade minimum cmake version supported: cmake 3.15 is first version accepting object lists for TARGET_OBJECTS
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants