Fix falcon constant time check in Valgrind #1646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix Falcon constant time check in Valgrind.
I review the Valgrind output and Falcon inline comments. It appears that a new line has been introduced, rendering the constant time check invalid. Consequently, adjusting the line location by 1 resolves the issue. To enhance clarity, I have separated the checks for Generic and AVX2. Additionally, I have eliminated some redundant checks for a more streamlined code.
Fixes #1617.