Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix falcon constant time check in Valgrind #1646

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

cothan
Copy link
Contributor

@cothan cothan commented Jan 1, 2024

This PR fix Falcon constant time check in Valgrind.
I review the Valgrind output and Falcon inline comments. It appears that a new line has been introduced, rendering the constant time check invalid. Consequently, adjusting the line location by 1 resolves the issue. To enhance clarity, I have separated the checks for Generic and AVX2. Additionally, I have eliminated some redundant checks for a more streamlined code.

Fixes #1617.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@dstebila
Copy link
Member

dstebila commented Jan 2, 2024

I'll run locally and let you know the results when they're done.

FYI it's possible to run Github actions locally. Install act and then you can run Github actions workflows in Docker containers; e.g., act --job constant-time-x64

Copy link
Member

@SWilson4 SWilson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run the tests locally; the Falcon tests pass now. Thanks very much!

tests/constant_time/sig/passes/falcon_keygen Outdated Show resolved Hide resolved
@dstebila
Copy link
Member

dstebila commented Jan 2, 2024

I'll run locally and let you know the results when they're done.

FYI it's possible to run Github actions locally. Install act and then you can run Github actions workflows in Docker containers; e.g., act --job constant-time-x64

They pass for me.

Co-authored-by: Spencer Wilson <spencer.wilson@uwaterloo.ca>
@dstebila dstebila merged commit b196974 into open-quantum-safe:main Jan 2, 2024
34 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Falcon constant time tests failing
3 participants