Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Format source code with ClangFormat. #224

Closed
ghost opened this issue Jul 20, 2023 · 1 comment
Closed

Format source code with ClangFormat. #224

ghost opened this issue Jul 20, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jul 20, 2023

Hello,

I'm wondering if this project could use ClangFormat to format the source code (both non-generated and generated).
It may be useful to achieve consistency in the code format.

What do authors think about it?
@baentsch
Copy link
Member

It would certainly make code more consistent(ly readable). So IMO it'd be a good enhancement. When setting the style, my preference would be the OpenSSL coding style.

@baentsch baentsch added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 20, 2023
@baentsch baentsch mentioned this issue Aug 31, 2023
Merged
feventura pushed a commit to EntrustCorporation/oqs-provider that referenced this issue Mar 16, 2024
@feventura
Fix open-quantum-safe#224: Add a clang-format that matches the best t…
ccc9861 
…he OpenSSL coding style. (open-quantum-safe#241)

This commit adds a `.clang-format` file at the root of the repository. This
`.clang-format` file tries to match the best the OpenSSL coding style.

This commit also reformats the existing code according to that `.clang-format`.

Finally, it adds a new CircleCI job to ensure that the code is well-formatted.

Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baentsch